Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CMake project to gz #244

Merged
merged 4 commits into from
Jun 25, 2022
Merged

Rename CMake project to gz #244

merged 4 commits into from
Jun 25, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented May 3, 2022

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 3, 2022
@chapulina chapulina changed the base branch from ch3/ignition-tick-tock to scpeters/gz_project_name May 3, 2022 23:48
Base automatically changed from scpeters/gz_project_name to main May 4, 2022 00:47
@scpeters
Copy link
Member

scpeters commented May 4, 2022

may need to replace ignition- with gz- in the following script to fix some tests:

@scpeters
Copy link
Member

scpeters commented May 4, 2022

may need to replace ignition- with gz- in the following script to fix some tests:

done in e54db0d and added an extra fix to the pkg-config file name in 12be647

@scpeters
Copy link
Member

scpeters commented May 4, 2022

I just noticed there is an ignition- that should change to gz- on the following line, but there's also a super weird 1.1 that makes no sense to me

the 1.1 is also in cmake/pkgconfig/ignition.pc.in

@scpeters
Copy link
Member

scpeters commented May 4, 2022

I just noticed there is an ignition- that should change to gz- on the following line, but there's also a super weird 1.1 that makes no sense to me

the 1.1 is also in cmake/pkgconfig/ignition.pc.in

some explanation for 1.1 in https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/104/page/1

I think we can remove it

@chapulina
Copy link
Contributor Author

I think we can remove it

Thanks, @scpeters , done in ccc12e3

@chapulina chapulina added the 🌱 garden Ignition Garden label May 12, 2022
@methylDragon
Copy link
Contributor

Be wary that changing the project names will cause regex replaces removing ignition to no-op, which would be a bug (at least as far as the rationale for doing the regex replace is)

I found one place where this happens, but I don't think I got them all:

@chapulina
Copy link
Contributor Author

regex replaces removing ignition to no-op

Good point, removed in a477d3b since this PR will go along all downstream project name changes anyway.

@chapulina
Copy link
Contributor Author

Good point, removed in a477d3b since this PR will go along all downstream project name changes anyway.

Ah that broke some test cases. Reverted in 73ef90e. We can address that in follow-up PRs.

Signed-off-by: methylDragon <[email protected]>
@chapulina chapulina merged commit dc51157 into main Jun 25, 2022
@chapulina chapulina deleted the gz_cmake_project branch June 25, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants