Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sdformat14 dsl #983

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix sdformat14 dsl #983

merged 1 commit into from
Aug 3, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 3, 2023

#982 added sdformat14 in ignition.dsl, which I think should be sdformat.dsl instead.

@azeey azeey requested a review from j-rivero as a code owner August 3, 2023 19:37
@azeey azeey requested a review from iche033 August 3, 2023 19:39
@azeey azeey self-assigned this Aug 3, 2023
@azeey
Copy link
Contributor Author

azeey commented Aug 3, 2023

diff:

Only in /tmp/current_xml_configuration: gz-sdformat14-debbuilder.xml
Only in /tmp/pr_xml_configuration: sdformat14-debbuilder.xml

@azeey azeey merged commit 1d3419c into master Aug 3, 2023
1 check passed
@azeey azeey deleted the azeey/fix_sdformat14 branch August 3, 2023 19:49
@j-rivero j-rivero mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@iche033 iche033 Awaiting requested review from iche033

Assignees

@azeey azeey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @j-rivero