-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to Focal for CI #565
Conversation
Signed-off-by: Louise Poubel <[email protected]>
testing with sdformat since it has a smaller number of jobs:
I'm not sure why it only changed |
it's apparently using |
Maybe we should get rid of that function, I think it predates Ignition |
it looks like it was added in 78ad01d but only used for sdformat. I think it's not needed since we don't support Xenial anymore. I think this was around the time we were using |
Signed-off-by: Steve Peters <[email protected]>
I've removed that function in 63a5436
|
the focal i386 job doesn't work
|
Focal dropped i386 support. I didn't even know we had any i386 CI. I think it's fine to throw that away. |
it would be interesting to replace the cc @j-rivero |
Since we are going to keep one node permanently in the buildfarm I think it is a good idea indeed. |
Question: if we drop Bionic here, can we claim that we are on the "official support" Tier in gazebosim/docs#215 ? |
I think we still have Bionic CI from GitHub Actions; this PR just changes the default platform in our Jenkins instance |
Co-authored-by: Jose Luis Rivero <[email protected]>
CI is failing in gazebosim/gz-common#267 without this change |
testing gazebo: https://build.osrfoundation.org/job/_dsl_gazebo/860/
|
it didn't change |
maybe we want to stick with bionic for gazebo? |
weird that the gazebo9 job switched to focal but not gazebo11 |
There was a modification using
Made some other changes to
With these changes the new run on top of master would be:
|
both gazebo focal builds are failing due to the dart package name
we should use distro-specific packages.apt files like ign-physics: |
I've redeployed from |
Made some progress on Gazebo classic in a separate branch chapulina/focal_CI...chapulina/focal_CI-jrivero
By now I have coded it in the |
the builds ran and most tests are passing but there was trouble running |
it might be simplest to keep gazebo CI on 18.04 for now |
I opened an issue with gazebo to track the 20.04 issues: gazebosim/gazebo-classic#3151 |
Agree. Done in f30b94d https://build.osrfoundation.org/job/_dsl_gazebo/864/console
|
🚀 💥 |
I forgot we need to update our views with the new job names. we'll need to update the build farmer scripts too |
I just saw this comment, and I had already done it in https://github.com/osrf/buildfarmer/pull/267
And I see you did this in #620 |
Our CI is currently defaulting to Bionic. Garden is going to drop Bionic though (see gazebosim/docs#215), so we should default to Focal instead, which is supported for all the Ignition versions we're currently working on (Citadel, Dome, Edifice, Fortress, Garden).
We should do a lot of testing before merging this; I can do it next week. I think we may need to hardcode
bionic
for Gazebo 9 and dependencies.