Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Focal for CI #565

Merged
merged 15 commits into from
Jan 5, 2022
Merged

Default to Focal for CI #565

merged 15 commits into from
Jan 5, 2022

Conversation

chapulina
Copy link
Contributor

Our CI is currently defaulting to Bionic. Garden is going to drop Bionic though (see gazebosim/docs#215), so we should default to Focal instead, which is supported for all the Ignition versions we're currently working on (Citadel, Dome, Edifice, Fortress, Garden).

We should do a lot of testing before merging this; I can do it next week. I think we may need to hardcode bionic for Gazebo 9 and dependencies.

Signed-off-by: Louise Poubel <[email protected]>
@scpeters
Copy link
Contributor

testing with sdformat since it has a smaller number of jobs:

Added items:
    GeneratedJob{name='sdformat-ci-main-focal-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat6-focal-amd64'}
    GeneratedJob{name='sdformat-install-sdformat6_pkg-focal-amd64'}
...
Unreferenced items:
    GeneratedJob{name='sdformat-ci-sdformat6-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat6_pkg-bionic-amd64'}
Disabled items:
    GeneratedJob{name='sdformat-install-sdformat6_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat6-bionic-amd64'}

I'm not sure why it only changed 6 and main to focal

@scpeters
Copy link
Contributor

scpeters commented Nov 20, 2021

I'm not sure why it only changed 6 and main to focal

it's apparently using Globals.get_gz11_ubuntu_distro() for the other release branches. Should we change that one too?

@chapulina
Copy link
Contributor Author

Should we change that one too?

Maybe we should get rid of that function, I think it predates Ignition

@scpeters
Copy link
Contributor

Should we change that one too?

Maybe we should get rid of that function, I think it predates Ignition

it looks like it was added in 78ad01d but only used for sdformat. I think it's not needed since we don't support Xenial anymore. I think this was around the time we were using gz11 branches on ignition repositories

@scpeters
Copy link
Contributor

Should we change that one too?

Maybe we should get rid of that function, I think it predates Ignition

it looks like it was added in 78ad01d but only used for sdformat. I think it's not needed since we don't support Xenial anymore. I think this was around the time we were using gz11 branches on ignition repositories

I've removed that function in 63a5436

Added items:
    GeneratedJob{name='sdformat-ci-main-focal-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat6-focal-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat9-focal-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat10-focal-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat11-focal-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat12-focal-amd64'}
    GeneratedJob{name='sdformat-ci-main-focal-i386'}
    GeneratedJob{name='sdformat-install-sdformat6_pkg-focal-amd64'}
    GeneratedJob{name='sdformat-install-sdformat9_pkg-focal-amd64'}
    GeneratedJob{name='sdformat-install-sdformat10_pkg-focal-amd64'}
    GeneratedJob{name='sdformat-install-sdformat11_pkg-focal-amd64'}
    GeneratedJob{name='sdformat-install-sdformat12_pkg-focal-amd64'}
...
Unreferenced items:
    GeneratedJob{name='sdformat-ci-main-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-main-bionic-i386'}
    GeneratedJob{name='sdformat-ci-sdformat10-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat11-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat12-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat6-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat9-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat10_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat11_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat12_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat6_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat9_pkg-bionic-amd64'}
Disabled items:
    GeneratedJob{name='sdformat-ci-sdformat10-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat6_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat6-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat11_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat9-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat11-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat10_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-main-bionic-i386'}
    GeneratedJob{name='sdformat-install-sdformat12_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-install-sdformat9_pkg-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-sdformat12-bionic-amd64'}
    GeneratedJob{name='sdformat-ci-main-bionic-amd64'}

@scpeters
Copy link
Contributor

the focal i386 job doesn't work

+++ sudo docker build --build-arg GID=1001 --build-arg USERID=1001 --build-arg USER=jenkins --tag building_job:1 .
Sending build context to Docker daemon  39.68MB

Step 1/49 : FROM osrf/ubuntu_i386:focal
manifest for osrf/ubuntu_i386:focal not found: manifest unknown: manifest unknown

@chapulina
Copy link
Contributor Author

the focal i386 job doesn't work

Focal dropped i386 support. I didn't even know we had any i386 CI. I think it's fine to throw that away.

@scpeters
Copy link
Contributor

the focal i386 job doesn't work

Focal dropped i386 support. I didn't even know we had any i386 CI. I think it's fine to throw that away.

it would be interesting to replace the i386 jobs with arm64 or armhf

cc @j-rivero

@j-rivero
Copy link
Contributor

it would be interesting to replace the i386 jobs with arm64 or armhf

cc @j-rivero

Since we are going to keep one node permanently in the buildfarm I think it is a good idea indeed.

@j-rivero
Copy link
Contributor

Our CI is currently defaulting to Bionic.

Question: if we drop Bionic here, can we claim that we are on the "official support" Tier in gazebosim/docs#215 ?

@scpeters
Copy link
Contributor

Our CI is currently defaulting to Bionic.

Question: if we drop Bionic here, can we claim that we are on the "official support" Tier in ignitionrobotics/docs#215 ?

I think we still have Bionic CI from GitHub Actions; this PR just changes the default platform in our Jenkins instance

@scpeters
Copy link
Contributor

CI is failing in gazebosim/gz-common#267 without this change

@scpeters
Copy link
Contributor

testing gazebo:

Build Status https://build.osrfoundation.org/job/_dsl_gazebo/860/

Added items:
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo9-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-install-one_liner-focal-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-focal-amd64'}
...
Unreferenced items:
    GeneratedJob{name='gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
Disabled items:
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia'}
Finished: SUCCESS

@scpeters
Copy link
Contributor

testing gazebo:

Build Status https://build.osrfoundation.org/job/_dsl_gazebo/860/

Added items:
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo9-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-install-one_liner-focal-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-focal-amd64'}
...
Unreferenced items:
    GeneratedJob{name='gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
Disabled items:
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia'}
Finished: SUCCESS

it didn't change GeneratedJob{name='gazebo-ci-gazebo11-bionic-amd64-gpu-nvidia'} to focal

@scpeters
Copy link
Contributor

maybe we want to stick with bionic for gazebo?

@scpeters
Copy link
Contributor

weird that the gazebo9 job switched to focal but not gazebo11

@j-rivero
Copy link
Contributor

weird that the gazebo9 job switched to focal but not gazebo11

There was a modification using ci_distro_default that make it to behave differently. I removed it:

  • Remove ci_distro_default hack 9457549

Made some other changes to gazebo.dsl to make it consistent, remove master branch:

  • Add testing jobs for Focal and Jammy Ubuntu packages 26b6e6c
  • Remove nightly support d40d863
  • Move master jobs to gazebo11 579eeb4

With these changes the new run on top of master would be:

Added items:
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo9-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo11-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo11-focal-i386-gpu-none'}
    GeneratedJob{name='gazebo-ci-coverage-focal-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci_BTRelease-gazebo11-focal-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTDebug-gazebo11-focal-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTCoverage-gazebo11-focal-amd64-gpu-none'}
    GeneratedJob{name='gazebo-install-one_liner-focal-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-focal-amd64'}
    GeneratedJob{name='gazebo-install-gazebo11_pkg-focal-amd64'}
    GeneratedJob{name='gazebo-install_ubuntu_official-gazebo9_pkg-focal-amd64'}
    GeneratedJob{name='gazebo-install_ubuntu_official-gazebo11_pkg-jammy-amd64'}
Existing items:
    GeneratedJob{name='gazebo-abichecker-any_to_any-ubuntu_auto-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo11-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo11-windows7-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo9-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo9-windows7-amd64'}
    GeneratedJob{name='gazebo-ci-manual_any'}
    GeneratedJob{name='gazebo-ci-pr_any-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any-windows7-amd64'}
    GeneratedJob{name='gazebo-install-one_liner-homebrew-amd64'}
    GeneratedJob{name='gazebo-install_ubuntu_official-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo11-debbuilder'}
    GeneratedJob{name='gazebo9-debbuilder'}
Unreferenced items:
    GeneratedJob{name='gazebo-ci-coverage-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo11-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-master-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-master-bionic-i386-gpu-none'}
    GeneratedJob{name='gazebo-ci-master-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci_BTCoverage-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTDebug-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTRelease-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-install-gazebo11_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
Disabled items:
    GeneratedJob{name='gazebo-install-gazebo11_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-ci_BTDebug-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci_BTRelease-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci-master-bionic-i386-gpu-none'}
    GeneratedJob{name='gazebo-ci-master-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci_BTCoverage-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-ci-master-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo11-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-coverage-bionic-amd64-gpu-nvidia'}

@scpeters
Copy link
Contributor

@scpeters
Copy link
Contributor

I've redeployed from master for now to fix gazebo CI:

@j-rivero
Copy link
Contributor

Made some progress on Gazebo classic in a separate branch chapulina/focal_CI...chapulina/focal_CI-jrivero

we should use distro-specific packages.apt files like ign-physics:

By now I have coded it in the dependencies_archive although would be great to have the dependencies in just one place. Out of the scope here.

gazebo11: Build Status

gazebo9: Build Status

@scpeters
Copy link
Contributor

both gazebo focal builds are failing due to the dart package name

E: Package 'libdart6-utils-urdf-dev' has no installation candidate

we should use distro-specific packages.apt files like ign-physics:

the builds ran and most tests are passing but there was trouble running python check_test_ran.py (it should use python3). This will require a code change in gazebo to work on focal

@scpeters
Copy link
Contributor

it might be simplest to keep gazebo CI on 18.04 for now

@scpeters
Copy link
Contributor

I opened an issue with gazebo to track the 20.04 issues: gazebosim/gazebo-classic#3151

@j-rivero
Copy link
Contributor

it might be simplest to keep gazebo CI on 18.04 for now

Agree. Done in f30b94d

https://build.osrfoundation.org/job/_dsl_gazebo/864/console

Added items:
    GeneratedJob{name='gazebo-ci-gazebo11-bionic-i386-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTRelease-gazebo11-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTDebug-gazebo11-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTCoverage-gazebo11-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-install-one_liner-focal-amd64'}
    GeneratedJob{name='gazebo-install_ubuntu_official-gazebo9_pkg-focal-amd64'}
    GeneratedJob{name='gazebo-install_ubuntu_official-gazebo11_pkg-jammy-amd64'}
Existing items:
    GeneratedJob{name='gazebo-abichecker-any_to_any-ubuntu_auto-amd64'}
    GeneratedJob{name='gazebo-ci-coverage-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo11-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo11-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo11-windows7-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-gazebo9-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci-gazebo9-windows7-amd64'}
    GeneratedJob{name='gazebo-ci-manual_any'}
    GeneratedJob{name='gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-pr_any-windows7-amd64'}
    GeneratedJob{name='gazebo-install-gazebo11_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-install-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo-install-one_liner-homebrew-amd64'}
    GeneratedJob{name='gazebo-install_ubuntu_official-gazebo9_pkg-bionic-amd64'}
    GeneratedJob{name='gazebo11-debbuilder'}
    GeneratedJob{name='gazebo9-debbuilder'}
Unreferenced items:
    GeneratedJob{name='gazebo-ci-master-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci-master-bionic-i386-gpu-none'}
    GeneratedJob{name='gazebo-ci-master-homebrew-amd64'}
    GeneratedJob{name='gazebo-ci_BTCoverage-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTDebug-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci_BTRelease-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
Disabled items:
    GeneratedJob{name='gazebo-ci_BTCoverage-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-install-one_liner-bionic-amd64'}
    GeneratedJob{name='gazebo-ci_BTDebug-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci-master-bionic-amd64-gpu-nvidia'}
    GeneratedJob{name='gazebo-ci_BTRelease-master-bionic-amd64-gpu-none'}
    GeneratedJob{name='gazebo-ci-master-bionic-i386-gpu-none'}
    GeneratedJob{name='gazebo-ci-master-homebrew-amd64'}

@chapulina
Copy link
Contributor Author

🚀 💥

@scpeters
Copy link
Contributor

scpeters commented Jan 5, 2022

I forgot we need to update our views with the new job names. we'll need to update the build farmer scripts too

@chapulina
Copy link
Contributor Author

we'll need to update the build farmer scripts too

I just saw this comment, and I had already done it in https://github.com/osrf/buildfarmer/pull/267

we need to update our views with the new job names

And I see you did this in #620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants