OSRFSourceCreation needs to install gz-cmake to generate sources #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source generation jobs needs to use a given Ubuntu distribution since the
make package_sourcecoming from gz-cmake needs, indeed, to have gz-cmake installed b2e8215. Not detected until now since the test case was gz-cmake which does not need a gz-cmake to be in place. Obviously. Changed to plugin in: 6866030.The installation of all gz-cmake available in the platform needs that plaform values reach the gz-source job from release.py. Done in 01cceab.
Not related but also in the PR a small change for OSRFReleasePy to use the new release.py script: 24cfea2