Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libgz-utils3-log and dev packages #4

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Add libgz-utils3-log and dev packages #4

merged 6 commits into from
Aug 21, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 19, 2024

Signed-off-by: Ian Chen <[email protected]>
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're implementing it as a component so we'll need to create a libgz-utils3-log and libgz-utils3-log-dev packages.

@iche033 iche033 force-pushed the spdlog_dep branch 3 times, most recently from cffabab to bbe67da Compare August 20, 2024 18:52
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 changed the title Add libspdlog-dev dependency Add libgz-utils3-log and dev packages Aug 20, 2024
@iche033
Copy link
Contributor Author

iche033 commented Aug 20, 2024

I think we're implementing it as a component so we'll need to create a libgz-utils3-log and libgz-utils3-log-dev packages.

updated to add the these 2 packages.

Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I just learned about the possibility of using curl to start these builds on jenkins. Here's what I used

curl -G https://build.osrfoundation.org/job/gz-utils3-debbuilder/buildWithParameters \
  -d 'PACKAGE=gz-utils3&VERSION=nightly&RELEASE_VERSION=1&DISTRO=noble&ARCH=amd64&SOURCE_TARBALL_URI=main&RELEASE_REPO_BRANCH=spdlog_dep&UPLOAD_TO_REPO=none&OSRF_REPOS_TO_USE=stable%20nightly&token=<replace_with_token>'

@@ -0,0 +1 @@
usr/lib/*/lib*-utils[0-99]-log.so.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a test run and it looks like there are some warnings: https://build.osrfoundation.org/job/gz-utils3-debbuilder/513/console

W: gz-utils3 source: binaries-have-file-conflict libgz-utils3 libgz-utils3-log usr/lib/x86_64-linux-gnu/libgz-utils3-log.so.3.0.0
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/include/gz/utils3/gz/utils/log.hh
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/include/gz/utils3/gz/utils/log/Export.hh
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/include/gz/utils3/gz/utils/log/Logger.hh
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/include/gz/utils3/gz/utils/log/SplitSink.hh
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/include/gz/utils3/gz/utils/log/detail/Export.hh
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/lib/x86_64-linux-gnu/cmake/gz-utils3-log/gz-utils3-log-config-version.cmake
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/lib/x86_64-linux-gnu/cmake/gz-utils3-log/gz-utils3-log-config.cmake
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/lib/x86_64-linux-gnu/cmake/gz-utils3-log/gz-utils3-log-targets-relwithdebinfo.cmake
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/lib/x86_64-linux-gnu/cmake/gz-utils3-log/gz-utils3-log-targets.cmake
W: gz-utils3 source: binaries-have-file-conflict libgz-utils3-dev libgz-utils3-log-dev usr/lib/x86_64-linux-gnu/pkgconfig/gz-utils3-log.pc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok made a few changes. The build is green now: https://build.osrfoundation.org/job/gz-utils3-debbuilder/517/

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 marked this pull request as ready for review August 21, 2024 22:03
@azeey azeey merged commit c66fadf into main Aug 21, 2024
@azeey azeey deleted the spdlog_dep branch August 21, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants