Added support for MobileSAM for snappier Gradio experience #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, but there are two bugs. 1, in your requirement.txt the new line that installs MobileSAM shouldn't have "pip install" in it. 2. in app.py you haven't set the SAM_checkpoint_url_dict value for the new vit_t, so it doesn't know where to download it from (maybe solve by adding an instruction to manually download it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support to MobileSAM which can be used to experience a snappier Gradio interface as it runs faster on cpu than the original SAM.
During tracking it does not impact much, especially on CUDA.
I have removed
args.device = "cuda:3"inapp.pyas it prevents from correctly selecting devices when running the script.This adds MobileSAM as a requirement.