Fix: Fix user defined dimensions #572

Ashutosh619-sudo · 2024-11-04T08:14:43Z

Description

Please add PR description here, add screenshots if needed

Clickup

Please add link here
https://app.clickup.com/1864988/v/l/6-901603904304-1

Summary by CodeRabbit

Bug Fixes
- Improved the retrieval of dimension values in the Sage Intacct integration, ensuring accurate syncing of user-defined dimensions.

No other changes were made to the functionality or structure of the integration.

coderabbitai · 2024-11-04T08:14:51Z

Walkthrough

The changes in this pull request modify the sync_user_defined_dimensions method within the SageIntacctConnector class in apps/sage_intacct/utils.py. The update alters the retrieval of dimension values to ensure the correct attribute is accessed, specifically changing from dimension_name to dimension['objectName']. No other aspects of the method's signature, return types, or control flow are affected, and the overall functionality of the class remains unchanged.

Changes

File	Change Summary
apps/sage_intacct/utils.py	Modified the `sync_user_defined_dimensions` method to retrieve dimension values using `dimension['objectName']` instead of `dimension_name`.

Possibly related PRs

feat: Add objectLabel as attribute type for user defined dimensions #571: This PR modifies the sync_user_defined_dimensions method in the same SageIntacctConnector class and file, changing how dimension values are derived, which is directly related to the changes made in the main PR.

Suggested reviewers

abhishek1234321

Poem

🐇 In the fields where dimensions play,
A change was made, hip-hip-hooray!
From names to objects, values align,
Syncing smoothly, all will be fine.
With hops of joy, we celebrate,
A code update that feels just great! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-11-04T08:14:59Z

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

github-actions · 2024-11-04T08:14:59Z

PR description must contain a link to a ClickUp (case-insensitive)

github-actions · 2024-11-04T08:15:19Z

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

github-actions · 2024-11-04T08:17:00Z

Tests	Skipped	Failures	Errors	Time
282	0 💤	0 ❌	0 🔥	39.393s ⏱️

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

apps/sage_intacct/utils.py (1)

634-634: Fix approved: Using correct attribute for dimension values.

The change from using dimension_name to dimension['objectName'] correctly fixes how dimension values are retrieved from Sage Intacct.

Consider adding unit tests for the sync_user_defined_dimensions method to prevent regression, especially around dimension value retrieval.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1c3569d and 33e7889.

📒 Files selected for processing (1)

apps/sage_intacct/utils.py (1 hunks)

* feat: Add objectLabel as attribute type for user defined dimensions * comment resolved * added script for wrong attributes in DB * Fix for user defined dimension issue

Ashutosh619-sudo added 5 commits October 30, 2024 14:02

feat: Add objectLabel as attribute type for user defined dimensions

ba44620

comment resolved

ea2a034

added script for wrong attributes in DB

1a18e43

Merge branch 'master' into fix_user_defined

443cdfe

Fix for user defined dimension issue

33e7889

Ashutosh619-sudo temporarily deployed to CI Environment November 4, 2024 08:14 — with GitHub Actions Inactive

github-actions bot added the size/XS Extra Small PR label Nov 4, 2024

Ashutosh619-sudo added the deploy Triggers deployment of active branch to Staging label Nov 4, 2024

Ashutosh619-sudo temporarily deployed to CI Environment November 4, 2024 08:15 — with GitHub Actions Inactive

Ashutosh619-sudo temporarily deployed to Staging November 4, 2024 08:15 — with GitHub Actions Inactive

Ashutosh619-sudo changed the title ~~Fix user defined~~ Fix: Fix user defined Nov 4, 2024

Ashutosh619-sudo changed the title ~~Fix: Fix user defined~~ Fix: Fix user defined dimensions Nov 4, 2024

coderabbitai bot reviewed Nov 4, 2024

View reviewed changes

ashwin1111 approved these changes Nov 4, 2024

View reviewed changes

Ashutosh619-sudo merged commit e3b0f5d into master Nov 4, 2024
8 of 10 checks passed

coderabbitai bot mentioned this pull request Nov 26, 2024

Fix: Rounding Amount in payload to 2 points #581

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Fix user defined dimensions #572

Fix: Fix user defined dimensions #572

Ashutosh619-sudo commented Nov 4, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

coderabbitai bot left a comment

Fix: Fix user defined dimensions #572

Fix: Fix user defined dimensions #572

Conversation

Ashutosh619-sudo commented Nov 4, 2024 • edited by coderabbitai bot Loading

Description

Clickup

Summary by CodeRabbit

coderabbitai bot commented Nov 4, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

Ashutosh619-sudo commented Nov 4, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)