Revert "cost-centers import rewrite (#345)" #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 239a507.
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
anishfyle
approved these changes
Oct 3, 2023
NileshPant1999
approved these changes
Oct 3, 2023
|
Shwetabhk
approved these changes
Oct 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 97.11% 97.11% -0.01%
==========================================
Files 50 49 -1
Lines 4743 4776 +33
==========================================
+ Hits 4606 4638 +32
- Misses 137 138 +1
|
labhvam5
pushed a commit
that referenced
this pull request
Oct 5, 2023
labhvam5
added a commit
that referenced
this pull request
Oct 5, 2023
labhvam5
added a commit
that referenced
this pull request
Oct 20, 2023
* Revert "Revert "cost-centers import rewrite (#345)" (#361)" This reverts commit a9c57ae. * expense_custom_field rework * adding test * adding test * adding test * adding test for code cov * adding test * lint fix * test for pre-save-mapping-trigger * fixing error handlign in pre-save trigger * migration script
labhvam5
added a commit
that referenced
this pull request
Oct 31, 2023
labhvam5
added a commit
that referenced
this pull request
Oct 31, 2023
* Revert "Revert "cost-centers import rewrite (#345)" (#361)" This reverts commit a9c57ae. * Import Tax Rework * removing tax-mapping-error code * removing old tax code * lint fixes * Import Vendors rework (#376) * Import Vendors rework * remove old vendor code * misc changes * lint fix * Test for auto-create-tax (#378) * removing old test * initial tests * adding test for tax and vendors (#379) * adding test for tax and vendors * adding tax test * adding vendors test * fixing test with work around * adding comments
labhvam5
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 239a507.