Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added year, guid into urls #428

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

derSoerrn95
Copy link
Contributor

  • Added some more files to .gitignore
  • added a function to return usermassinfo (cause in this data u can see daily gifts)

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #428 into master will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   51.61%   52.23%   +0.61%     
==========================================
  Files           9        9              
  Lines         463      469       +6     
  Branches       39       39              
==========================================
+ Hits          239      245       +6     
  Misses        221      221              
  Partials        3        3
Impacted Files Coverage Δ
fut/urls.py 83.33% <100%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae35e28...a98c999. Read the comment docs.

@gdomod
Copy link

gdomod commented Oct 8, 2018

why do u not update the
# remote config - should be refresh every x seconds rc = requests.get('https://www.easports.com/fifa/ultimate-team/web-app/content/7D49A6B1-760B-4491-B10C-167FBC81D58A/2019/fut/config/companion/remoteConfig.json').json()

and
# TODO: card info url not found yet card_info_url = 'https://fifa19.content.easports.com/fifa/fltOnlineAssets/7D49A6B1-760B-4491-B10C-167FBC81D58A/2019/fut/items/web/' # TODO: get hash from somewhere, dynamic year

from parsed guid and year ?

@derSoerrn95
Copy link
Contributor Author

I don´t know if @oczkers wants to use it. so we can use it in the future if we want.

core: get settings on launch futapi#429
@oczkers
Copy link
Member

oczkers commented Oct 22, 2018

I don´t know if @oczkers wants to use it. so we can use it in the future if we want.

Sure, what's the point of making additional request if it's not used anywhere :-)?

This change is good but i tried to avoid it because we've got now two exactly the same requests for https://www.easports.com/de/fifa/ultimate-team/web-app/ - one is core and one in urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants