Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unversioned TeamID infrastructure. #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JanX2
Copy link
Contributor

@JanX2 JanX2 commented Oct 1, 2021

This change allows keeping the TeamID out of the project files. This way people can just clone the git repo, add their TeamID in a copy of the file "DEVELOPMENT_TEAM.xcconfig.template" then named "DEVELOPMENT_TEAM.xcconfig" and signing of the iOS Example will magically work.

This is described in detail in the file "Shared.xcconfig".

This is described in detail in the file "Shared.xcconfig".
@fulldecent
Copy link
Owner

Thank you for sharing. Is this approach documented or advocated from anywhere?

Please see that our project setup comes from here. https://github.com/fulldecent/swift5-module-template I want to synchronize any changes we are doing with there.

@JanX2
Copy link
Contributor Author

JanX2 commented Oct 2, 2021

@fulldecent
You can have a look at all the repos that I have added this to. This approach makes OSS development much easier. I tried to generate a link to a search for this, but github seems to have issues there:
https://github.com/search?q=user%3AJanX2+filename%3ADEVELOPMENT_TEAM.xcconfig

I originally got the concept and idea from:
https://github.com/lapcat/Bonjeff

This approach has been used here:
https://github.com/JanX2/Cog

It has also been adapted from this idea here:
https://github.com/JanX2/BookPlayer

This is limited to the iOS Example project. The library remains untouched.

@fulldecent
Copy link
Owner

Thank you for the notes.

Would like to leave the issue open for a bit to collect feedback here.

@JanX2
Copy link
Contributor Author

JanX2 commented Oct 4, 2021

@fulldecent Sure!

@JanX2
Copy link
Contributor Author

JanX2 commented Oct 26, 2021

@fulldecent What are your thoughts on these changes?

@JanX2
Copy link
Contributor Author

JanX2 commented Nov 10, 2021

@fulldecent Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants