Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve union case serialization & added tests #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

realvictorprm
Copy link

I prefer this way of serialization of union cases. It's well usable from other languages like C#.

@realvictorprm
Copy link
Author

The major change in here is that union cases are now serialized as objects with fields.
This can be done because the tuple of a union case can contain field names and if they don't contain a field name it is always there because the compiler autogenerates these.

@vsapronov
Copy link
Collaborator

I will consider this change. Though it's a breaking change (and not a breaking bugfix) to current logic. So such change in logic should be either under config flag or introduced in major release.

@realvictorprm
Copy link
Author

I did this minimal change during company time. I'm not using it anymore there but I'm willing to polish it in my private time, however this will take some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants