Lilypond 2.24

[fedelibre]

No description provided.

[fedelibre]

I'm away from home and I forgot the charger of my laptop. I might reply to any feedback from 3rd of January.

[jeanas]

This isn't complete, is it? There is stuff to update in ly/data/ (importantly, this includes lists of properties).

[fedelibre]

Yes, I should have set it to draft. I'll continue when I'm back at home.

[PeterBjuhr]

Yes, I should have set it to draft. I'll continue when I'm back at home.

I've set it to draft now!

[fedelibre]

This isn't complete, is it? There is stuff to update in ly/data/ (importantly, this includes lists of properties).

I've updated _lilypond_data.py using the Makefile. But there's also makeschemedata.py, which needs some corrections. Can you have a look at it? You know Scheme, while I'm totally ignorant.

[fedelibre]

I made a try with makeschemedata.py, but there are a few issues to be solved:

1. We lost almost all the scheme_keywords. See how guileWords is populated in makeschemedata.py.
2. I had to comment lyVars.remove('parser') to avoid an error, but I don't understand what I'm doing. Maybe parser was removed in Guile 2?

[jeanas]

I had to comment lyVars.remove('parser') to avoid an error, but I don't understand what I'm doing. Maybe parser was removed in Guile 2?

In older days, all music functions had a required parser argument (and a location argument), but this isn't the case anymore. My guess is that it is related to this.

[jeanas]

@fedelibre I have fixed the problem with Scheme keywords and the two others I noticed. I pushed the commit to your branch, I hope that's OK with you.

To be honest, the way makeschemedata.py works is pretty terrible. But I'm not asking you to change it in this PR; we can do that later, and one of the projects on my packed LilyPond TODO list is to add the ability to output its keywords to LilyPond itself so that every editor project doesn't have to reimplement it.

[fedelibre]

I had to comment lyVars.remove('parser') to avoid an error, but I don't understand what I'm doing. Maybe parser was removed in Guile 2?

In older days, all music functions had a required parser argument (and a location argument), but this isn't the case anymore. My guess is that it is related to this.

Ok, then we'd better delete that commented line?

Go ahead and feel free to add more commits on my branch. When you've finished I think we can merge it.
Thanks!

[jeanas]

I think we're good to go now. I went through the diff again, and with the latest fixes, I don't see any oddities anymore. All changes look expected to me.

[jeanas]

Removed the commented line and merged. Thanks @fedelibre for initiating this!

[fedelibre]

Wait, what about this HTML entities?

diff --git a/ly/data/_scheme_data.py b/ly/data/_scheme_data.py
index 7fb635e..95d68cd 100644
--- a/ly/data/_scheme_data.py
+++ b/ly/data/_scheme_data.py
@@ -1,8 +1,36 @@
 #generated by makeschemedata.py
 
-version="2.18"
+version="2.24"
 
 scheme_keywords = [
+    '&assertion',
+    '&condition',
+    '&error',
+    '&i/o',
+    '&i/o-decoding',
+    '&i/o-encoding',
+    '&i/o-file-already-exists',
+    '&i/o-file-does-not-exist',
+    '&i/o-file-is-read-only',
+    '&i/o-file-protection',
+    '&i/o-filename',
+    '&i/o-invalid-position',
+    '&i/o-port',
+    '&i/o-read',
+    '&i/o-write',
+    '&implementation-restriction',
+    '&irritants',
+    '&lexical',
+    '&message',
+    '&no-infinities',
+    '&no-nans',
+    '&non-continuable',
+    '&serious',
+    '&syntax',
+    '&undefined',
+    '&violation',
+    '&warning',
+    '&who',

[jeanas]

Oops 😳

I knew these things started with an & in Guile and didn't pay attention to the amp; while scrolling...

I'll fix it in a follow-up PR.

[jeanas]

#152