Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code block highlighting #418

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Jan 31, 2024

Checklist:

Closes #387

Copy link

socket-security bot commented Jan 31, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@tiptap/[email protected] Transitive: environment, filesystem +49 7.51 MB _bdbch
npm/[email protected] None +5 4.04 MB wooorm

View full report↗︎

@Sembauke Sembauke marked this pull request as ready for review January 31, 2024 09:06
@Sembauke Sembauke requested a review from a team as a code owner January 31, 2024 09:06
sidemt
sidemt previously requested changes Feb 1, 2024
Copy link
Member

@sidemt sidemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block is working fine, but now the inline code block is showing backticks around it (which you have fixed in PR #203)

If it's difficult to handle both inline code and multi-line code blocks with a single button, it's ok to add a selectbox to choose either inline code or code block.

Edit: I think I found how to fix it. It was a bit complicated to add as suggestions so I will open a separate PR later. Other changes LGTM 👍

@sidemt sidemt dismissed their stale review February 1, 2024 14:55

I will open another PR

@sidemt sidemt enabled auto-merge (squash) February 1, 2024 14:56
@sidemt sidemt merged commit 3b4b25e into main Feb 1, 2024
7 checks passed
@sidemt sidemt deleted the feat/code-blocks-with-highlighting branch February 1, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlight in code blocks in editor and preview
2 participants