Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaml-workflow for building rdma_perf app #93

Merged
merged 10 commits into from
Nov 17, 2024
Merged

yaml-workflow for building rdma_perf app #93

merged 10 commits into from
Nov 17, 2024

Conversation

maximilianheer
Copy link
Member

@maximilianheer maximilianheer commented Nov 15, 2024 •
edited
Loading

Description

Attempt to include an automatized build of the coyote rdma_perf-example. This included a) a new .yaml-file which describes the build of this example-app, b) updates of the referenced network-module (as a git submodule) to change the cmake-version to 3.5 and remove all requirements for VivadoHLS.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • A new research paper code implementation
  • Other

Tests & Results

📝 Please describe the tests that you ran to verify your changes. Also include any numerical results (throughput/latency etc.) relavant to the change.

Checklist

  • I have commented my code and made corresponding changes to the documentation.
  • I have added tests/results that prove my fix is effective or that my feature works.
  • My changes generate no new warnings or errors & all tests successfully pass.

@maximilianheer
Cleared up the spelling mistake in build_rdma.yaml and remove the src…
8f2db13 
… bash in both build_rdma.yaml and build_static.yaml upon request of Benjamin
bo3z
bo3z approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, going to wait for the synthesis to pass and squash-merge

@bo3z bo3z merged commit 48572ba into master Nov 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo3z bo3z bo3z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximilianheer @bo3z