Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Gandi libdns to 1.0.3 #673

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

nustiueudinastea
Copy link
Contributor

@nustiueudinastea nustiueudinastea commented Jan 26, 2024

upgraded to the latest version of gandi libdns, which fixes an issue where new records could not be created

See #619

Copy link
Owner

@foxcpp foxcpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some incompatible changes in latest commits - libdns/gandi@5a26022
I guess it is a mess we will have to bring downstream by breaking config compatibility as it is no longer possible to specify an API key in libdns/gandi despite them being still supported.

Also, libdns/gandi maintainer overwrites existing releases, leading to issues with Go tooling (#555, libdns/gandi#9), therefore it is important to specify a particular commit in go.mod using pseudoversions.

@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (d8232a4) 52.49% compared to head (08671bc) 52.43%.
Report is 1 commits behind head on master.

Files Patch % Lines
internal/libdns/gandi.go 0.00% 11 Missing ⚠️
internal/libdns/provider_module.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   52.49%   52.43%   -0.06%     
==========================================
  Files         128      128              
  Lines       13311    13324      +13     
==========================================
  Hits         6987     6987              
- Misses       5667     5680      +13     
  Partials      657      657              
Flag Coverage Δ
integration 34.08% <0.00%> (-0.04%) ⬇️
unit 53.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@foxcpp foxcpp merged commit 394bc9e into foxcpp:master Jan 27, 2024
3 of 5 checks passed
@foxcpp
Copy link
Owner

foxcpp commented Jan 27, 2024

Thanks for your work!

@nustiueudinastea nustiueudinastea deleted the update-libdns-gandi branch January 28, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants