Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote ascii functions to elemental #886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jalvesz
Copy link
Contributor

@jalvesz jalvesz commented Nov 10, 2024

Promote ascii functions from pure to elemental for potentially better optimization and ease use for array expressions manipulation.

Copy link
Contributor

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I remember that some older versions of gfortran had issues with elemental functions and character . However, that seems not an issue here as all tests pass with all supported gfortran versions. LGTM, thank you @jalvesz

@jalvesz
Copy link
Contributor Author

jalvesz commented Nov 13, 2024

Do you remember if it was a compile-time problem or a run-time problem? maybe it would be better to add array-like tests also ? I don't recall running into such problems.

@perazz
Copy link
Contributor

perazz commented Nov 17, 2024

I can't find a link right now in my bugzilla - I suggest we wait for another while, and if no further comments arise, this PR can be merged imho.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @perazz . I guess that the specs should be updated too.
Re: the history, I don't remember any specific reasons why they were not defined as elemental. These procedures were some of the first to be implemented in stdlib and the structure was not well defined yet (see e.g., #32 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants