Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse algebra support with OOP API #760
Sparse algebra support with OOP API #760
Changes from 41 commits
5d0ff52
b1dcbf6
c63c0dd
d940ebd
72481be
a7cb6be
d48dde5
93c5c3a
6241ca3
0f2ee3b
c1a85c4
2606691
c34ac70
3126d16
c0bbabb
2c2431d
d64a045
6786859
d926581
22b477c
d165b8b
8f72559
87c867a
59fe24e
43ab25f
838b159
c74ad09
14bfef9
23be647
1d9dabc
8278f38
87bfd10
3fa318b
4aae5b4
14e9be0
6e679f5
91e619a
7117d16
5b0aadf
c0438f0
e18b3fc
79534b3
5f35174
b3de016
181760b
147a5c9
c832eeb
22a70b1
9223345
827a1ef
21a8547
da9f171
1cbb982
a3c155a
2fb4e83
e78c026
f25e07d
c7035c9
82950e0
93c1e55
c1f30f6
4c16f4a
944212d
dd4dbd8
2d7701e
98a564b
b65d933
a94272e
e4c1f58
14e2c17
b53eca2
65e3fcb
2f56cd4
941de3a
575c426
db73fdc
697afa2
c97e665
ac100a1
9879a9c
dde88a7
6ae038b
3596f3f
a21d1e8
c8d94a3
82dbe02
a8aa247
66b0ce2
4b41aa1
ab112e6
bc0021b
7279461
a4d9306
cd30636
b68b4c8
62c702b
581d215
59d33f0
beafb3c
7a26174
3746331
3dfcecd
89a993e
ae02481
680d35d
5ceef37
7e45901
22cd23e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the option to use either C or Fortran indexing. My only concern is: what is the advantage of hard-coding it into the data structure? Shouldn't the internal representation be unique (e.g., 1-based)? My fear is that handling two options for the internal representation would be too complicate when more complex functions are implemented. Instead, wouldn't it be better to add this option only to the
set/get
interfaces. For example:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like having subroutines to maximize performance and avoid the issues with function assignment. I wonder if we should also provide 'clean' function interfaces to generate new objects? Just giving it a thought.
They would probably pair better with overloaded operators for example, but also in other ways. For example, one could have:
This would require to add an interface