Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (metrics) initialize metrics handler in temporal sdk if provided #202

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

laouji
Copy link
Contributor

@laouji laouji commented Nov 28, 2024

relates to: ENG-1546

after talking to Temporal customer support they recommended enabling temporal sdk metrics in order to better measure worker latency and decide if we are scheduling too much work for our workers to handle

Capture d’écran 2024-11-28 à 17 08 03

The Schedule-To-Start time of an Activity Task in seconds. A Schedule-To-Start Timeout can be set when an Activity Execution is spawned. This metric is useful for ensuring Activity Tasks are being processed from the queue in a timely manner. Some SDKs may include the activity_type label, but the metric should not vary by type, as it does not influence the rate at which tasks are pulled from the queue.

source: https://docs.temporal.io/references/sdk-metrics#activity_schedule_to_start_latency

@laouji laouji marked this pull request as ready for review November 28, 2024 15:54
@laouji laouji requested a review from a team as a code owner November 28, 2024 15:54
@laouji laouji added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 499692d Nov 28, 2024
7 checks passed
@laouji laouji deleted the feat/temporal-metrics branch November 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants