docs(readme): fix underscore colours guide #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lljbash
changed the title
lljbash
changed the title
|
ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to this answer,
\e[58:2:R:G:Bmis considered a "rarely used incorrect format" for truecolor.I tested it on Windows Terminal with WSL2, and it didn’t work. After changing the format to
\e[58::2:R:G:Bm, which is noted as the "commonly used standard way," it worked as expected.The change I made is as follows:
I’d appreciate it if someone could test this on more platforms.
Related Issue(s)
Screenshots