fix: Fixed the FBW Logo + Vercel Logo appearing in the map page #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is not how we should fix this, it should just be fixed with CSS |
|
Ah alright, Thanks for letting me know |
Fixed footer appearing in the map page with css
|
It seems to be a lil typo in Edit: I’m not a Tailwind expert, but from the documentation, it looks like |
@Benjozork changes have been made, ans it's now handled with css, Noted that I also would recommand waiting for @ItzARz solution to be pulled into this PR, his proposition is better fitted. |
Revert "Fixed footer appearing in the map page with css"
fixed logos appearing in the map.
NathanInnes
reviewed
Nov 7, 2024
Co-authored-by: Nathan Innes <[email protected]>
NathanInnes
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixed the FBW Logo + Vercel Logo appearing in the map page (https://flybywiresim.com/map/) when the user zoon - unzoom.
Screenshots