job-ingest: improve cleanup and stats output #6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: when validator/frobnicator processes do not exit after their stdin is closed, 'flux module stats job-ingest' does not list them. Provide a count of "trash" processes. Fixes flux-framework#6432
Problem: when job-ingest shuts down, it SIGKILLs any running workers, but ignores workers whose stdin has been closed but might be stuck. Send SIGKILL to lingering workers that have been placed in the slot's trash list. Note: this is not strictly necessary because the broker SIGKILLs any running subprocesses when it shuts down, but it seems proper for the creator of the mess to clean it up.
Problem: there is no test coverage for a validator that refuses to be shut down. Add a test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6438 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 524 524
Lines 87672 87693 +21
=======================================
+ Hits 73324 73346 +22
+ Misses 14348 14347 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a count of "trash" processes for each work crew to the
flux module stats job-ingestoutput, so that there is some indication that the module is tracking subprocesses whose input has been closed, but that have not yet exited.While in there I noticed that the cleanup code that sends SIGKILL to running workers doesn't signal workers that are lingering in the trash list. Add code to signal those too and a test.