indicate held jobs in the INFO column of flux jobs output
#6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Held jobs (those with priority=0) are not denoted in default flux-jobs(1) output, but this would be useful for admins and users to quickly determine why these jobs are not being scheduled. Update the `contextual_info` property of the `JobInfo` class (which supplies the content for the INFO column) to return "held" for jobs with urgency=0 and "priority-hold" for jobs with priority=0. Fixes flux-framework#6426
Problem: The documentation of the `contextual_info` field in flux-jobs(1) does not include that "held" is a possible result. Update it.
Problem: No tests in the testsuite ensure that the `contextual_info` field in flux-jobs output indicates held jobs. Add a couple tests that ensure the INFO field presents held jobs as either "held" or "priority-hold".
|
Thanks! I'll set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements @ryanday36's suggestion in #6426. It extends the
flux jobs{contextual_info}field (INFO) to check for a priority of 0 and printsheldifurgencyis also zero, otherwisepriority-hold.