-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: kvs: call content.flush before checkpoint #6240
base: master
Are you sure you want to change the base?
WIP: kvs: call content.flush before checkpoint #6240
Commits on Sep 3, 2024
-
Problem: An accidental 'd' was added to remove, making it "removed". Fix spelling.
Configuration menu - View commit details
-
Copy full SHA for f94d669 - Browse repository at this point
Copy the full SHA f94d669View commit details
Commits on Sep 4, 2024
-
Problem: A test in t0028-content-backing-none.t incorrectly calls checkpoint_put when it should call checkpoint_get. Fix invalid test.
Configuration menu - View commit details
-
Copy full SHA for d8bd26e - Browse repository at this point
Copy the full SHA d8bd26eView commit details -
content: correct message unpack style
Problem: The typical message unpack style is to place key names and storage pointers on the same line, but that is not done in several locations in the content and content backing modules. Correct code style to be more consistent to the rest of flux-core.
Configuration menu - View commit details
-
Copy full SHA for 039b1dc - Browse repository at this point
Copy the full SHA 039b1dcView commit details -
content: require backing store for checkpoint
Problem: A backing store is required for content.flush but it is not required for content.checkpoint-put. This is inconsistent and can lead to checkpointing problems done the line. Require content.checkpoint-put to only work if there is a backing store available. As a consequence, remove code that handled "cached" checkpoints when a backing store is not available. Fixes flux-framework#6251
Configuration menu - View commit details
-
Copy full SHA for 721bffa - Browse repository at this point
Copy the full SHA 721bffaView commit details -
t: remove/adjust checkpoint tests
Problem: Now that the content backing store is required for checkpoints, many tests fail. Remove tests that previously assumed that checkpointing worked without a content backing store. Adjust some tests that now have an new error message.
Configuration menu - View commit details
-
Copy full SHA for d5e4301 - Browse repository at this point
Copy the full SHA d5e4301View commit details -
t: cover "none" backing store checkpoints
Problem: There is no coverage to ensure that the "none" backing store works identically to when no backing store is never loaded. Add coverage in t0028-content-backing-none.t.
Configuration menu - View commit details
-
Copy full SHA for 72db5f3 - Browse repository at this point
Copy the full SHA 72db5f3View commit details -
t: cover FLUX_KVS_SYNC on ENOSPC
Problem: There is no coverage to ensure FLUX_KVS_SYNC fails when there is no longer space on disk. Add coverage to t0090-content-enospc.t.
Configuration menu - View commit details
-
Copy full SHA for 263b6b0 - Browse repository at this point
Copy the full SHA 263b6b0View commit details -
t: cover FLUX_KVS_SYNC without backing store
Problem: There is no coverage to ensure FLUX_KVS_SYNC does not work if there is no backing store. Add coverage in t1010-kvs-commit-sync.t.
Configuration menu - View commit details
-
Copy full SHA for 061c789 - Browse repository at this point
Copy the full SHA 061c789View commit details -
kvs: call content.flush before checkpoint
Problem: When the KVS module is unloaded, a checkpoint of the root reference is attempted. However, a content.flush is not done beforehand. This could result in an invalid checkpoint reference as data is not guaranteed to be flushed to the backing store. Solution: Call content.flush before checkpointing. Fixes flux-framework#6237
Configuration menu - View commit details
-
Copy full SHA for cb88b17 - Browse repository at this point
Copy the full SHA cb88b17View commit details