Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: kvs: call content.flush before checkpoint #6240

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Sep 3, 2024

  1. t: fix typo

    Problem: An accidental 'd' was added to remove, making it "removed".
    
    Fix spelling.
    chu11 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f94d669 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. t: fix invalid test

    Problem: A test in t0028-content-backing-none.t incorrectly
    calls checkpoint_put when it should call checkpoint_get.
    
    Fix invalid test.
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d8bd26e View commit details
    Browse the repository at this point in the history
  2. content: correct message unpack style

    Problem:  The typical message unpack style is to place key names
    and storage pointers on the same line, but that is not done in
    several locations in the content and content backing modules.
    
    Correct code style to be more consistent to the rest of flux-core.
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    039b1dc View commit details
    Browse the repository at this point in the history
  3. content: require backing store for checkpoint

    Problem: A backing store is required for content.flush but it
    is not required for content.checkpoint-put.  This is inconsistent
    and can lead to checkpointing problems done the line.
    
    Require content.checkpoint-put to only work if there is a backing
    store available.  As a consequence, remove code that handled
    "cached" checkpoints when a backing store is not available.
    
    Fixes flux-framework#6251
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    721bffa View commit details
    Browse the repository at this point in the history
  4. t: remove/adjust checkpoint tests

    Problem: Now that the content backing store is required for checkpoints,
    many tests fail.
    
    Remove tests that previously assumed that checkpointing worked without
    a content backing store.  Adjust some tests that now have an new
    error message.
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d5e4301 View commit details
    Browse the repository at this point in the history
  5. t: cover "none" backing store checkpoints

    Problem: There is no coverage to ensure that the "none" backing
    store works identically to when no backing store is never loaded.
    
    Add coverage in t0028-content-backing-none.t.
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    72db5f3 View commit details
    Browse the repository at this point in the history
  6. t: cover FLUX_KVS_SYNC on ENOSPC

    Problem: There is no coverage to ensure FLUX_KVS_SYNC fails when
    there is no longer space on disk.
    
    Add coverage to t0090-content-enospc.t.
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    263b6b0 View commit details
    Browse the repository at this point in the history
  7. t: cover FLUX_KVS_SYNC without backing store

    Problem: There is no coverage to ensure FLUX_KVS_SYNC does not
    work if there is no backing store.
    
    Add coverage in t1010-kvs-commit-sync.t.
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    061c789 View commit details
    Browse the repository at this point in the history
  8. kvs: call content.flush before checkpoint

    Problem: When the KVS module is unloaded, a checkpoint of the root
    reference is attempted.  However, a content.flush is not done
    beforehand.  This could result in an invalid checkpoint reference
    as data is not guaranteed to be flushed to the backing store.
    
    Solution: Call content.flush before checkpointing.
    
    Fixes flux-framework#6237
    chu11 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cb88b17 View commit details
    Browse the repository at this point in the history