flux-jobs: support W presentation type, update cute output format #5179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A test in t2800-jobs-cmd.t had a message that was inconsistent to what the test performed. Update the test message to list what is tested. Update the format of the message to avoid it being super long.
|
re-pushed, fix spelling and linting issues found by CI. Edit: oops another time, isort fail. |
Problem: When outputting wide characters (e.g. emojis) in flux-jobs,
the alignment of output can be poor due to the characters having
different output widths.
Solution: Add a new W presentation type that can adjust formating
of the form "(<|>)N", e.g. {id.emoji:>12W}. The output width will
be adjusted given the number of wide characters that exist in the
string.
Note that this presentation type does not help for all output scenarios,
as it depends on the width of the output and width of the alignment,
but it definitely helps in some scenarios.
Problem: The W presentation type is not documented in flux-jobs(1) Add paragraph covering it.
Problem: The cute format in flux-jobs is not cute enough! Solution: Update the format to use id.emoji over id.f58.
Problem: There is no coveragage for id.emoji and the W presentation type. Add some coverage in t2800-jobs-cmd.t.
Codecov Report
@@ Coverage Diff @@
## master #5179 +/- ##
==========================================
- Coverage 83.15% 83.15% -0.01%
==========================================
Files 455 455
Lines 78035 78050 +15
==========================================
+ Hits 64890 64899 +9
- Misses 13145 13151 +6
|
|
FYI, sadly this doesn't quite work for my font combination I guess 🙁 |
|
doh! i wonder if this is even solvable within the framework of how we do output formats. I suppose in some worst case it could loop through all potential outputs, see what the longest emoji length is, then adjust field width .... ugh |
|
Yeah, that's my worry as well. I guess we do already loop through all outputs to check for empty fields to handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
flux-jobs(1)cute output does not throw enough emojis in your face.Solution: Update
flux-jobscuteformat to useid.emojioverid.f58. Support newWpresentation adjuster to make the output prettier.