add-bank: add a check when adding a root bank
#509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The structure of the flux-accounting database hierarchy of banks and users assumes there is only one root bank, but multiple root banks can be added with the "add-bank" command. Add a check when adding a root bank that one does not already exist. If so, raise an exception.
Problem: There exists a few unit tests that do not make the assumption that the flux-accounting database does not enforce a 1-root-bank limit, but now that there is a check for this in add_bank(), these tests fail. Edit these tests to account for the check that when a root bank is added, a root bank does not already exist.
Problem: There exists no sharness test for trying to add more than one root bank to the bank_table and ensuring than an exception is raised. Add a test.
|
Thanks! Setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Mentioned in #508, the structure of the flux-accounting database hierarchy of banks and users assumes there is only one root bank (e.g when calculating fair-share), but multiple root banks can be added with the
add-bankcommand.This PR adds a check when adding a root bank that one does not already exist. If so, an exception is raised.
A couple of existing tests that did not make this assumption have been edited to account for this new check, and I've also added a simple sharness test that ensures an exception is raised when trying to add more than one root bank.
Fixes #508