Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove io sample #2490

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Remove io sample #2490

merged 3 commits into from
Nov 22, 2024

Conversation

ericwindmill
Copy link
Contributor

This sample has been moved to my personal Github, because we shouldn't maintain samples that are tied to events.

  • Moved sample to personal repo
  • Removed sample from this repo
  • Updated README here and the link to this repo in the YouTube video

@domesticmouse
Copy link
Contributor

If that were the justification, I'd have to delete half of my codelabs.

I'd vote we keep samples that have value for our users, and AI is pretty hawt right now. So unless we have an alternate AI sample to replace it with, I'd be leaning heavily on the keep it.

@ericwindmill
Copy link
Contributor Author

If that were the justification, I'd have to delete half of my codelabs.

I'd vote we keep samples that have value for our users, and AI is pretty hawt right now. So unless we have an alternate AI sample to replace it with, I'd be leaning heavily on the keep it.

We do have an alternative sample: https://github.com/flutter/samples/tree/main/gemini_tasks
I prefer that sample because this a vast majority of the code in this sample has nothing to do with Gemini. It's gonna be laborious to maintain, especially given that AI moves so quickly.

Also, there are samples in the pub package and a few more in google-gemini github I would much prefer to link to these from the forthcoming index page on the website, or even from the readme in this repo.

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericwindmill ericwindmill merged commit 66ab725 into main Nov 22, 2024
13 checks passed
@ericwindmill ericwindmill deleted the remove-io-talk-sample branch November 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants