Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for Flutter 3.19 release #2146

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Prep for Flutter 3.19 release #2146

merged 8 commits into from
Feb 1, 2024

Conversation

ericwindmill
Copy link
Contributor

@ericwindmill ericwindmill commented Jan 24, 2024

Prepping for the next stable release in February.

@ericwindmill ericwindmill changed the title format varfont_shader_puzzle Prep for release [not ready] Jan 24, 2024
@domesticmouse
Copy link
Contributor

You might as well land this change now. There will be further changes required, and it'll reduce the size and complexity of the actual change on release day

@ericwindmill ericwindmill changed the title Prep for release [not ready] Dart format varfont_shader_puzzle and add to beta CI Jan 25, 2024
@ericwindmill ericwindmill marked this pull request as ready for review January 25, 2024 13:54
@ericwindmill ericwindmill changed the title Dart format varfont_shader_puzzle and add to beta CI Dartfmt varfont_shader_puzzle and add to beta CI Jan 25, 2024
@ericwindmill
Copy link
Contributor Author

ericwindmill commented Jan 25, 2024

@domesticmouse Based on recently merged PR's, it looks like some CI is expected to fail. LMK if that's not the case or if anything is failing here that shouldn't be

@domesticmouse domesticmouse self-assigned this Jan 27, 2024
@domesticmouse
Copy link
Contributor

@domesticmouse Based on recently merged PR's, it looks like some CI is expected to fail. LMK if that's not the case or if anything is failing here that shouldn't be

I usually wind up massaging the CI projects as required to make the CI as green as possible, to prevent known failures from masking unknown failures.

@domesticmouse
Copy link
Contributor

Assuming this PR is green (modulo the Android build) I'd suggest landing this ASAP.

@ericwindmill ericwindmill changed the title Dartfmt varfont_shader_puzzle and add to beta CI Fix varfont_shader_puzzle and add to beta CI, remove experimental/material_3_demo from master CI Jan 31, 2024
@ericwindmill ericwindmill changed the title Fix varfont_shader_puzzle and add to beta CI, remove experimental/material_3_demo from master CI Prep for Flutter 3.19 release Feb 1, 2024
@ericwindmill ericwindmill merged commit 78990c6 into main Feb 1, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants