This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Shrink image sizes of attachments in Reply app. #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Aug 22, 2023
| @@ -151,6 +151,7 @@ class _ShrineAppState extends State<ShrineApp> | |||
|
|
|||
| return ScopedModel<AppStateModel>( | |||
| model: _model.value, | |||
| // ignore: deprecated_member_use | |||
There was a problem hiding this comment.
Don't think this should be updated now because the framework change has not made it to g3 yet (and it had to be reverted once)
jonahwilliams
requested review from
Renzo-Olivares,
domesticmouse and
zanderso
zanderso
approved these changes
Aug 22, 2023
Renzo-Olivares
approved these changes
Aug 22, 2023
|
So how do I update these goldens? I don't see the download button in the Github UI like https://github.com/flutter/gallery/blob/main/test_goldens/README.md shows |
|
I see links under the step "Upload goldens if tests fail", but I get auth errors(?) when I click on them. Not sure who is on the right ACLs for this repo. Maybe @HansMuller or @goderbauer know? |
|
I also get auth errors. @guidezpl would probably know how to do this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the investigation of flutter/flutter#132690 , we discovered that the Reply image previews are the fully size 2000x2000 images. The decoding of these images is putting the device under heavy strain which is making it hard to diagnose other performance issues.