-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add initial firebase storage #5
Conversation
83236b3
to
61b18b1
Compare
727668d
to
2bf68dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR work was in progress, Dart version was updated.
When testing dart analyze --fatal-infos
on my local environment, I found a few issues.
(Please check other packages as well)
packages/firebase_storage/example/integration_test/extratest_e2e.dart
Outdated
Show resolved
Hide resolved
packages/firebase_storage/example/integration_test/extratest_e2e.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: Hosung Kim [email protected]
Signed-off-by: Hosung Kim [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Hosung Kim [email protected]