Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add initial firebase storage #5

Merged
merged 3 commits into from
Sep 19, 2023
Merged

feat(storage): add initial firebase storage #5

merged 3 commits into from
Sep 19, 2023

Conversation

hs0225
Copy link
Contributor

@hs0225 hs0225 commented Aug 1, 2023

Signed-off-by: Hosung Kim [email protected]

@hs0225 hs0225 added the wip label Aug 1, 2023
@hs0225 hs0225 force-pushed the dev/storage branch 6 times, most recently from 83236b3 to 61b18b1 Compare August 2, 2023 06:31
@hs0225 hs0225 force-pushed the dev/storage branch 6 times, most recently from 727668d to 2bf68dd Compare August 21, 2023 01:24
@hs0225 hs0225 removed the wip label Aug 22, 2023
@hs0225 hs0225 requested review from daeyeon and JSUYA and removed request for daeyeon August 22, 2023 01:02
@hs0225
Copy link
Contributor Author

hs0225 commented Aug 22, 2023

cc @JSUYA @Swanseo0 @daeyeon

Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this PR work was in progress, Dart version was updated.
When testing dart analyze --fatal-infos on my local environment, I found a few issues.
(Please check other packages as well)

packages/cloud_functions/tizen/build_def.prop Show resolved Hide resolved
packages/firebase_storage/README.md Outdated Show resolved Hide resolved
packages/firebase_storage/README.md Outdated Show resolved Hide resolved
packages/firebase_storage/README.md Show resolved Hide resolved
packages/firebase_storage/tizen/src/flutter_types.hpp Outdated Show resolved Hide resolved
Copy link

@Swanseo0 Swanseo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hs0225 hs0225 merged commit 557c0b0 into main Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants