Show more symbols on profiling builds #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The artifact sizes are unacceptably large. Embedders shouldn't have dependencies on the dart runtime. |
bbrto21
reviewed
Jun 8, 2021
|
@swift-kim Could you add |
swift-kim
reviewed
Jun 10, 2021
swift-kim
reviewed
Jun 11, 2021
swift-kim
approved these changes
Jun 11, 2021
swift-kim
pushed a commit
that referenced
this pull request
Jun 14, 2021
* Show more symbols on profiling builds * Remove libdart dependency * Add libdart dependency for builds with enabled profiling * Fix shell/platform/tizen/BUILD.gn formatting * Remove dependency on libdart * Remove unnecessary import
swift-kim
added a commit
that referenced
this pull request
Jun 16, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change turns on more symbols in profiling view of DevTools and thus partially solves #95.