Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FlutterDesktopViewGetResourceId #52

Merged

Conversation

xiaowei-guan
Copy link
Contributor

Replace surface id with resource id for fixing overlap issue on Tizen TV 6.0.

@JSUYA
Copy link
Member

JSUYA commented Dec 5, 2023

@xiaowei-guan Hi Can you please tell us the PR or codes that uses FlutterDesktopViewGetResourceId()?
If used only in plugins, wouldn't it be better to use a method channel (window channel or platform(view) channel)?

@xiaowei-guan
Copy link
Contributor Author

@xiaowei-guan Hi Can you please tell us the PR or codes that uses FlutterDesktopViewGetResourceId()? If used only in plugins, wouldn't it be better to use a method channel (window channel or platform(view) channel)?

Hello, this new API just for video_palyer_avplay plugin(xiaowei-guan/plugins@f3cff83)

@swift-kim swift-kim changed the title Implement get resource id Implement FlutterDesktopViewGetResourceId Dec 5, 2023
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI :Maybe below code could get the same result.
I think, we are already using ext api in embedder, so current code is also good

static Eina_Bool window_show(void *data ,
                                        int type EINA_UNUSED,
                                        void *event ) {
  Ecore_Wl2_Event_Window_Show *ev =
      static_cast<Ecore_Wl2_Event_Window_Show *>(event);
  if (data) {
    *reinterpret_cast<uint32_t *>(data) =
        static_cast<unsigned int>(ev->data[0]);
  }

  return ECORE_CALLBACK_PASS_ON;
}
...
ecore_event_handler_add(ECORE_WL2_EVENT_WINDOW_SHOW, window_show,
                          &resource_id_);

@xuelian-bai xuelian-bai merged commit f6da9cc into flutter-tizen:master Dec 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants