Skip to content

Commit

Permalink
[tools] Remove requests dependency (#37)
Browse files Browse the repository at this point in the history
  • Loading branch information
swift-kim authored May 22, 2023
1 parent ea9783c commit 64ba146
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
1 change: 0 additions & 1 deletion .github/workflows/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
- name: Run gclient sync
run: |
pip3 install requests
gclient config --name=src --unmanaged https://github.com/${{ github.repository }}
gclient sync -v --no-history --shallow --nohooks
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install -y rpm2cpio cpio binutils-${{ matrix.triple }}
pip3 install requests
- name: Install depot_tools
run: |
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ The Flutter embedder for Tizen.
- [LLVM](https://apt.llvm.org) (10 or later)
- `sudo apt install clang-12`
- Additional dependencies
- `sudo apt install git python3 python3-pip rpm2cpio cpio`
- `sudo apt install git python3 rpm2cpio cpio`
- `sudo apt install binutils-arm-linux-gnueabi binutils-aarch64-linux-gnu binutils-i686-linux-gnu`
- `pip3 install requests`

### Environment setup

Expand Down
9 changes: 5 additions & 4 deletions tools/download_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import requests
import shutil
import sys
import urllib.request
Expand All @@ -22,11 +21,13 @@ def main():
if stamp_file.is_file():
stamp = stamp_file.read_text().strip()

version = ''
# The GitHub REST API cannot be used in the company network due to an
# "API rate limit exceeded" error. The following is a workaround.
request = requests.get('{}/latest'.format(github_url))
redirected_url = request.url
redirected_url = ''
with urllib.request.urlopen('{}/latest'.format(github_url)) as response:
redirected_url = response.geturl()

version = ''
if '/tag/' in redirected_url:
version = redirected_url.split('/tag/')[-1]

Expand Down

0 comments on commit 64ba146

Please sign in to comment.