Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H264: add fluendo's LCEVC decoder for H264 #166

Closed
wants to merge 1 commit into from
Closed

H264: add fluendo's LCEVC decoder for H264 #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions fluster/decoders/gstreamer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,3 +900,15 @@ def __init__(self) -> None:
self.api = "SW"
self.caps = self.caps + ",format=S16LE"
super().__init__()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci is failing on check -> trailing whitespace here


@register_decoder
class FluendoH264LCEVCDecoder(GStreamer10Video):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets stick to the naming we have in plugin -> FluendoLCEVCHWH264Decoder

"""LCEVC-H264 decoder for GStreamer 1.0"""

codec = Codec.H264
decoder_bin = "flulcevchwvah264dec"
provider = "Fluendo"
api = "HW"
hw_acceleration = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be true?

name = f"{provider}-{codec.value}-{api}-LCEVC-Gst1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we are not really consistent with naming, but i like the idea of having plugins name in front of Gst1.0 like in Fluendo-H.265-HW-hwvah265dec-Gst1.0 (in place of LCEVC in this case, put lcevchwvah264dec).

Loading