Fluster "installed" version #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
suggested changes
Oct 20, 2023
| line = "=" * 100 | ||
| print( | ||
| f"{line}\n" | ||
| f'WARNING: Using "{TEST_SUITES_DIR_SYS}" with fluster uninstalled.\n' |
There was a problem hiding this comment.
maybe it would be worth just printing the test suite directory without the warning when running from a local directory ? This would then be useful for people running fluster locally.
I'm just not sure how useful the warning text really is :-).
There was a problem hiding this comment.
The goal with installed/uninstalled flavor is to deprecate and delete code added in a22f609
If a sys dir want to be used, the installed version must be used.
ylatuya
requested changes
Oct 23, 2023
ylatuya
requested changes
Oct 24, 2023
|
TODO when approved:
|
ylatuya
requested changes
Nov 22, 2023
ylatuya
approved these changes
Nov 24, 2023
rgonzalezfluendo
force-pushed
the
platformdirs
branch
4 times, most recently
from
414e603
to
fe9e74e
Compare
| use_emoji=not args.no_emoji, | ||
| verbose=args.verbose if "verbose" in args else False, |
There was a problem hiding this comment.
Verbose should be a global argument. But this change breaks the BS.
rgonzalezfluendo
force-pushed
the
platformdirs
branch
from
fe9e74e
to
8d2dace
Compare
* before commit results_dir is `__file__ /../results` * after commit results_dir is `/tmp/fluster_results` The global arguments `output` can be used for custom temporal results dir.
Checking if fluster is uninstalled with the existence of the '.git' dir. For installed fluster, the site platform dirs is preferred for test suites dir if exists. If not, user platform dirs will be used, that is, ~/.local/share/fluster (or XDG_DATA_HOME) will be used if /usr/share/fluster (or XDG_DATA_DIRS) doesn't exist. For resources dir the user platform dirs is always used. For uninstalled fluster, the usage of platform test suites dir [2] is deprecated and it will be deleted in the future. The platformdirs[1] lib was not used on purpose. The reason is to avoid introducing the first external non-dev dependency. [1] https://github.com/platformdirs/platformdirs [2] a22f609
Needed to print internal direcotries.
rgonzalezfluendo
pushed a commit
that referenced
this pull request
Nov 27, 2023
With the last PR [1], the Debian package stopped working. Fluster was checking first path in XDG_DATA_DIRS instead of iterate over them. Debian package install the test suites in `/usr/share/fluster/test_suites/`. And a normal value of XDG_DATA_DIRS is `/home/user/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share/:/usr/share/` Fixes #157 [1] #145
rgonzalezfluendo
pushed a commit
that referenced
this pull request
Nov 27, 2023
With the last PR [1], the Debian package stopped working. Fluster was checking first path in XDG_DATA_DIRS instead of iterate over them. Debian package install the test suites in `/usr/share/fluster/test_suites/`. And a normal value of XDG_DATA_DIRS is `/home/user/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share/:/usr/share/` Fixes #157 [1] #145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
tempfile.gettempdir()for temporal results directory:__file__ /../results/tmp/fluster_resultsThe global argument
outputcan be used for custom temporal results dir.Using platform dirs to execute installed fluster.
Checking if fluster is uninstalled with the existence of the '.git' dir.
For installed fluster, the site platform dirs is preferred if exists. If not, user platform dirs will be used, that is,
~/.local/share/fluster(orXDG_DATA_HOME) will be used if/usr/share/fluster(orXDG_DATA_DIRS) doesn't exist.Fluster tries to use the platformdirs[1] lib. But if not found, it fallbacks to a simple implementation. The reason is to avoid introducing the first external dependency.
[1] https://github.com/platformdirs/platformdirs