This repository has been archived by the owner on Aug 2, 2020. It is now read-only.
Quarantine new instances by default. #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maplefeline
commented
Feb 5, 2020
| Rails.logger.info "Quarantining new domain #{username}@#{domain}" | ||
| admin = Account.joins(:user).merge(User.staff).first | ||
| ReportWorker.perform_in( | ||
| 2.minutes, |
There was a problem hiding this comment.
This is an arbitrary way of delaying the execution until the current database transaction completes, there are probably better ways to achieve it.
There was a problem hiding this comment.
without the delay, this first user remains active and unblocked.
maplefeline
commented
Feb 5, 2020
| comment: 'Quarantined new domain', | ||
| forward: false, | ||
| ) | ||
| DomainBlock.new(domain: domain, severity: :suspend, reject_media: true, reject_reports: true).save! |
There was a problem hiding this comment.
The flags here are a paranoid level of verbose, I am aware severity: :suspend should be equivalent.
|
Something that probably should be documented with this feature, if rails/web logs the event then that was probably initiated by a worker on the other side, if Sidekiq/worker logs the event then the new domain was probably linked from an already approved domain. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up https://github.com/maplefeline/mastodon-fork/tree/citizenship.
I'm not sure this is enough to close #113 but I'm a bit stuck at the moment. Mapping an administration flag to disable this is lost to me, and without the flag approaching the tests is challenging.
Given I have seen my instance get hit with 50 new domains in an hour I'm going to continue running this patch on https://social.holomaplefeline.net