Document that tag-pattern of git checker is not needed in some cases #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasinvein
reviewed
Jul 27, 2022
| @@ -289,6 +289,9 @@ exactly one match group (the pattern will be used to extract version from tag): | |||
| By default tags are sorted based on version number extracted from tag. | |||
| To disable sorting and keep order from `git ls-remote`, set `sort-tags` to `false`. | |||
|
|
|||
| If the tags are just the version without anything else e.g. `1.0`, you don't need to | |||
There was a problem hiding this comment.
It also matches versions prefixed with v, like v1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.