Adding workaround for the case when a connect gets stuck forever #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For a green build #2 needs to be merged first. |
|
Merged your other PR - if you could fix the conflict here I'll take a look. |
| // It turns out that under certain unknown circumstances the connect waits forever: https://github.com/twitter/cloudhopper-smpp/issues/117 | ||
| // That's why the future is canceled 1 second after the specified timeout. | ||
| // This is a workaround and hopefully not needed after the switch to netty 4. | ||
| if (!connectFuture.await(connectTimeoutMillis + 1000)) { |
There was a problem hiding this comment.
I originally used two minutes just to be on the safe side, but I think 1 second should do the trick. I don't want to use the same time as the real timeout in order not to interfere with the real timeout.
|
I fixed the conflict long time ago, but I forgot to comment again. Fixed ;) |
l1101100
added a commit
to l1101100/cloudhopper-smpp
that referenced
this pull request
Mar 8, 2016
satanatoly
added a commit
to RestComm/cloudhopper-smpp
that referenced
this pull request
Aug 7, 2017
… awaitUninterruptibly() as per fizzed#1
satanatoly
pushed a commit
to RestComm/cloudhopper-smpp
that referenced
this pull request
Sep 14, 2017
Fixed issue with connection being stuck on awaitUninterruptibly() as per fizzed#1 Fixed blocking issue at channel write. Related issue RestComm/smpp-extensions#28
olenara
added a commit
to RestComm/cloudhopper-smpp
that referenced
this pull request
Sep 28, 2017
…per fizzed#1 Fixed blocking issue at channel write. Related issue RestComm/smpp-extensions#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to fix twitter-archive#117 with this pull request.
I was never able to reproduce the issue in our test environment. In the end I put my change on some of the production servers and I could verify via behavior and logging that it actually fixed my problem.
This is a workaround and I guess the problem is somewhere inside netty. But since there is already a branch to move to netty 4, I don't think it is worth to track down the bug there.
PS: Currently bugs can not be reported to this project.