fem: explicitly set use_canonical_quadrature_point_ordering=False for… #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… special node types
ksagiyam
force-pushed
the
ksagiyam/use_canonical_quadrature_point_ordering
branch
from
1266026
to
f958f69
Compare
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix firedrakeproject/firedrake#3874
Follow up [PR for interior facet integration of hex] (#317)
Some ufl-gem translation contexts for interior facet integration (such as the ones for
CellVolumeandFacetArea) do not even need to check if quadrature point ordering on the '+' and '-' sides agree or not. This PR explicitly setPointSetcontext.use_canonical_quadrature_point_ordering=Falsefor those translation contexts.Firedrake tests: firedrakeproject/firedrake#3878