Remove unnecessary loopy transform that produces warnings #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
reviewed
Nov 19, 2024
| @@ -264,9 +264,6 @@ def generate(impero_c, args, scalar_type, kernel_name="loopy_kernel", index_name | |||
| preambles=preamble | |||
| ) | |||
|
|
|||
| # Prevent loopy interchange by loopy | |||
| knl = lp.prioritize_loops(knl, ",".join(ctx.index_extent.keys())) | |||
There was a problem hiding this comment.
This could have some performance degradation. For example, for kernels of the form:
u[n,j] = 1.it is preferred to have "j"-loop nested within "n"-loop. This preferred nesting can be guaranteed by performing appropriate calls to lp.prioritize_loops. Without those priorities loopy might generated code with the loops permuted in an unfavorable manner.
There was a problem hiding this comment.
Ah good to know! I should dig into how we build this ctx.index_extent because it is including 'sibling' loop nests when it shouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this will help fix a lot of the warnings we have been seeing.