Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4547: Refactor vmm builder code to simplify logic that creates the microVM to boot #4603

Closed
wants to merge 2 commits into from

Conversation

andr3wy
Copy link
Contributor

@andr3wy andr3wy commented May 7, 2024

Changes

-Refactor code building VMM to be more modular and reduce compile time conditionals.
...

Reason

-Currently, the logic to create a Vmm object is scattered across vmm/lib.rs and vmm.builder.rs files and it is quite convoluted and some times difficult to follow. Moreover, there is a lot of architecture specific code inserted in arbitrary places which further increases the un-readability. Apart from the aesthetics and readability aspect, the state of the code makes it quite difficult to unit test.

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

andr3wy and others added 2 commits May 6, 2024 22:08
Signed-off-by: Andrew Yao <[email protected]>
…n addition to continuing to reduce compile time conditionals.

Signed-off-by: Andrew Yao <[email protected]>
Co-authored-by: Himanshu Reddy <[email protected]>
Co-authored-by: Goldin Vo <[email protected]>
Signed-off-by: Andrew Yao <[email protected]>
@JonathanWoollett-Light
Copy link
Contributor

Related to #4411

@roypat
Copy link
Contributor

roypat commented Jul 15, 2024

Hi @andr3wy,
thanks for having a go at this issue. Since this is still in a very early draft state, and hasn't seen any update in a few months I'll go ahead and close this for now, so that potentially another contributor can pick this task up in the future. Please feel free to reopen it though if you want to come back to it at some point!

@roypat roypat closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants