Backport PR #4242 to support all logger level case variants #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <[email protected]> Signed-off-by: Sudan Landge <[email protected]>
Add unit test to cover all cases of LevelFilter. Remove redundant logic from levelfilter_from_str because levelfilter_from_str_all_variants is a better place to put the logic. Signed-off-by: Jonathan Woollett-Light <[email protected]> Signed-off-by: Sudan Landge <[email protected]>
wearyzen
changed the title
wearyzen
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.5 #4270 +/- ##
=================================================
Coverage 82.96% 82.97%
=================================================
Files 223 223
Lines 28456 28471 +15
=================================================
+ Hits 23609 23623 +14
- Misses 4847 4848 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wearyzen
added
the
Status: Awaiting review
Adding an entry for #4270 which is a backport of #4242. Signed-off-by: Sudan Landge <[email protected]>
roypat
approved these changes
Nov 24, 2023
kalyazin
approved these changes
Nov 27, 2023
wearyzen
merged commit b85d0b7
into
firecracker-microvm:firecracker-v1.5
4 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backport PR #4242
This commit re-introduces this support such that all variants should again be supported.
Reason
#4047 updated
parsing the logger level filter. It removed all case variants outside
fully uppercase (e.g.
INFO) and the 1st character being upper case(e.g.
Info) this removed support for other previously supportedvariants e.g.
info.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.