do not rely on 0 plugins for detecting headlesschrome #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm running BotD in production and with one of my user I diagnosed that
navigator.plugins.length
returns0
on his browser.He is running Vivaldi 7.0.3495.18 (Stable channel) on Windows and without any extension installed the browser gives no plugins in the list:
I'm proposing to remove the classification that if the plugins list is empty, then it's a headless chrome.
First because now for
--headless=new
, the value fornavigator.plugins.length
is not empty anymore. It's5
. Everyone is already using that new headless method or spoofing the value fornavigator.plugins
And second, the API
navigator.plugins
is no longer recommended: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/plugins. So we may run into some false positive if some browser decides to not disclose the plugins list as part of protecting the privacy of the user.