Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hello World example #1526

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Update Hello World example #1526

merged 1 commit into from
Oct 18, 2022

Conversation

lobzison
Copy link
Contributor

Seems that after the 0.34.0 release some things have changed, but they are not reflected in the examples.

There is a #1254, but it seems to be opened for a different root cause. But it can be closed after the merge

Copy link
Collaborator

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@joroKr21 joroKr21 merged commit 031023c into finagle:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants