Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing workflow to use the actual default branch name #43

Closed
wants to merge 3 commits into from

Conversation

caendesilva
Copy link

Since the default branch for template repositories is 3.x, I suggest that this workflow should also use that instead of the non-existent main branch.

Since the default branch for template repositories is 3.x, I suggest that this workflow should also use that instead of the non-existent main branch.
@chrisreedio
Copy link

@caendesilva Should the 'branch names' in the badges of the readme also be updated to reflect this?

@caendesilva
Copy link
Author

@caendesilva Should the 'branch names' in the badges of the readme also be updated to reflect this?

Indeed. Pushed another commit. Thanks!

@chrisreedio
Copy link

chrisreedio commented Nov 3, 2023

@caendesilva At this point, I feel I should probably just fork this and submit my own PR so I don't nag you anymore but to save the maintainers another PR, I think there is one more issue here that I've just found.

https://github.com/filamentphp/plugin-skeleton/blob/3.x/.github/workflows/fix-php-code-styling.yml

This file is called fix-php-code-styling.yml and it runs the Fix PHP Code Styling workflow.

In the README.md on one of the lines you fixed the branch on, that workflow file + name is incorrect.

It mentions style-issues instead of styling. Will review on the affected line.

Thanks for all your work on this!

-- Edit: Didn't want to imply you made this mistake, just have been noticing it in the repos I've spawned from this template.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Reed <[email protected]>
@chrisreedio
Copy link

@awcodes Any chance we could get some of these simple PR's merged into the skeleton if you have some spare time?

Let me know if I can help in anyway!

Your time and work is hugely appreciated! 🙏❤

@awcodes
Copy link
Contributor

awcodes commented Nov 15, 2023

This is a skeleton. Changing this to 3.x doesn't make sense because a new plugin will likely not be a 3.x version. Main makes sense here because that is the default branch for all new git repos.

@chrisreedio
Copy link

chrisreedio commented Nov 15, 2023

This is a skeleton. Changing this to 3.x doesn't make sense because a new plugin will likely not be a 3.x version. Main makes sense here because that is the default branch for all new git repos.

If I initialize a new repo from this template, it starts with 3.x being the default branch, not main. 😕

@awcodes
Copy link
Contributor

awcodes commented Nov 15, 2023

Are you clicking the use this template button in GitHub or cloning it down?

@awcodes
Copy link
Contributor

awcodes commented Nov 15, 2023

Honestly I just set up a bash command to clone it down, rm -rf .git, then run the configure.php.

@awcodes
Copy link
Contributor

awcodes commented Nov 15, 2023

I don't like using the button and having to create a repo if I don't know if I'm even going to keep it or not. That way I can just create a repo when and if I'm ready to.

@chrisreedio
Copy link

Are you clicking the use this template button in GitHub or cloning it down?

I have always clicked the button on the web interface and then just clone my new repo.

For what it's worth (next to nothing), when using the web button it maintains the link between the new project and that it was created from this skeleton.

@awcodes
Copy link
Contributor

awcodes commented Nov 16, 2023

I believe you. It's weird to me that it does that though.

@awcodes
Copy link
Contributor

awcodes commented Nov 16, 2023

Could probably just use the main branch and merge 3.x into it.

@awcodes
Copy link
Contributor

awcodes commented Nov 21, 2023

Main branch has been created and set to default. This should resolve the issues you were having.

Thanks.

@awcodes awcodes closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants