-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testing workflow to use the actual default branch name #43
Conversation
Since the default branch for template repositories is 3.x, I suggest that this workflow should also use that instead of the non-existent main branch.
@caendesilva Should the 'branch names' in the badges of the readme also be updated to reflect this? |
Indeed. Pushed another commit. Thanks! |
@caendesilva At this point, I feel I should probably just fork this and submit my own PR so I don't nag you anymore but to save the maintainers another PR, I think there is one more issue here that I've just found. https://github.com/filamentphp/plugin-skeleton/blob/3.x/.github/workflows/fix-php-code-styling.yml This file is called In the It mentions Thanks for all your work on this! -- Edit: Didn't want to imply you made this mistake, just have been noticing it in the repos I've spawned from this template. |
Co-authored-by: Chris Reed <[email protected]>
@awcodes Any chance we could get some of these simple PR's merged into the skeleton if you have some spare time? Let me know if I can help in anyway! Your time and work is hugely appreciated! 🙏❤ |
This is a skeleton. Changing this to 3.x doesn't make sense because a new plugin will likely not be a 3.x version. Main makes sense here because that is the default branch for all new git repos. |
If I initialize a new repo from this template, it starts with |
Are you clicking the use this template button in GitHub or cloning it down? |
Honestly I just set up a bash command to clone it down, rm -rf .git, then run the configure.php. |
I don't like using the button and having to create a repo if I don't know if I'm even going to keep it or not. That way I can just create a repo when and if I'm ready to. |
I have always clicked the button on the web interface and then just clone my new repo. For what it's worth (next to nothing), when using the web button it maintains the link between the new project and that it was created from this skeleton. |
I believe you. It's weird to me that it does that though. |
Could probably just use the main branch and merge 3.x into it. |
Main branch has been created and set to default. This should resolve the issues you were having. Thanks. |
Since the default branch for template repositories is 3.x, I suggest that this workflow should also use that instead of the non-existent main branch.