forked from SonixQMK/qmk_firmware
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sn32 rgb v3 #3
Open
fightforlife
wants to merge
897
commits into
fightforlife:sn32_develop_k66v1_rgb_v3
Choose a base branch
from
dexter93:sn32_rgb_v3
base: sn32_develop_k66v1_rgb_v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sn32 rgb v3 #3
fightforlife
wants to merge
897
commits into
fightforlife:sn32_develop_k66v1_rgb_v3
from
dexter93:sn32_rgb_v3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: wb <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: Duncan Sutherland <[email protected]>
* update layouts/default/readme.md * add tkl_wkl layouts to layouts/default * amend layouts/default/readme.md * `tsangan_wkl` to `wkl` * Update readme.md * update keymap.c * local testing corrections applied * add layouts/community readmes * minor text correction(s) * Apply suggestions from code review * further copyright header changes
* Correct `LAYOUT_all` data Corrects incorrect key sizes and positioning. * Correct `LAYOUT_tkl_ansi_tsangan` data Corrects incorrect matrix assignments on the bottom row. * Correct `LAYOUT_tkl_ansi_tsangan_split_bs_rshift` data Corrects incorrect matrix assignments on the bottom row. * Set `LAYOUT_all` as an alias Sets `LAYOUT_all` as an alias for `LAYOUT_tkl_ansi_tsangan_split_bs_rshift`, because the layout and matrix data for these two macros is identical.
* First commit * Fix keycode range and color on indicator * bit of cleanup * prettify * Update keyboards/novelkeys/nk_classic_tkl/keymaps/default/keymap.c Co-authored-by: Joel Challis <[email protected]> * Update keyboards/novelkeys/nk_classic_tkl/info.json Co-authored-by: Joel Challis <[email protected]> * Update keyboards/novelkeys/nk_classic_tkl/info.json Co-authored-by: Joel Challis <[email protected]> * readme fix --------- Co-authored-by: yiancar <[email protected]> Co-authored-by: Joel Challis <[email protected]>
* Port K12 from sn32_master * Ran through clang-format and removed my own wip keymap * Replace wrong measurements * Forgot to copy licenses over * Apply requested changes * Oops * Adjust RGB matrix coordinates and flags * Use VIA V3 schema --------- Co-authored-by: turai <[email protected]>
* Add gravity tkl * license adjusted * fix license and remarks * fix remarks: identation, remove rules.mk and info.json, other remarks * remove NO_PIN from key matrix * B1 B2 added to keyboard.json; default keymap updated * force_nkro removed * PID and VID changed. NK_TOGG added to keymap
* Initial configuration for board * cleanup * add default keymap rules, swap right control and the up arrow in g_led_config, and add a comment showing how the key matrix correlates to the led matrix * requested PR changes
…xQMK#395) * Update info.json Remove animations to reduce firmware size * Update info.json Remove Animations to reduce firmware size --------- Co-authored-by: PythonDeployer <[email protected]>
migrate configs in header
only use custom scanning if the wiring is shared
depending on configuration
happy new year!
LED output differs depending on the module used, as well as the current limiting setup. Introduce a luminosity correction factor that will limit output on overdriven channels, allowing fine tuning through PWM scaling.
fix ROW2COL PWM bug on COL2ROW A column would light up when pressed on this scenario
dexter93
force-pushed
the
sn32_rgb_v3
branch
from
September 13, 2024 00:07
4889fd3
to
93db451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist