Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-tsc): updated createVueLanguagePlugin syntax, version pin #398

Merged
merged 5 commits into from
Sep 5, 2024
Merged

fix(vue-tsc): updated createVueLanguagePlugin syntax, version pin #398

merged 5 commits into from
Sep 5, 2024

Conversation

daniluk4000
Copy link
Contributor

Does the same as in #395 + compatibility with new internal API

Closes vuejs/language-tools#4755
Closes #397

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0b76c03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Sep 4, 2024 •
edited
Loading

✅ Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 0b76c03
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/66d9701fe69ac10008d69782
😎 Deploy Preview https://deploy-preview-398--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniluk4000 daniluk4000 mentioned this pull request Sep 4, 2024
Closed
@daniluk4000
Copy link
Contributor Author

@fi3ework friendly pinging there as well.

While updating dependencies, I also rebuilt lockfile and then rolled it back due to other incompatibilities.

But anyways, this PR should be good to go IMO, I have copied original removed method (removeEmitGlobalTypes) since it wasn't used for nothing I guess, and removed isRootFile check since it's gone on vue-tsc level.

I have also tested this with one of my projects. Works like a charm.

@nielsvh2103
Copy link

+1 looks good, waiting for merge

@fi3ework
Copy link
Owner

fi3ework commented Sep 5, 2024

Thank you very much.

@fi3ework fi3ework merged commit 5f5b92a into fi3ework:main Sep 5, 2024
8 checks passed
@fi3ework fi3ework mentioned this pull request Sep 5, 2024
Closed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 6, 2024
@renovate
Update dependency vite-plugin-checker to v0.8.0
84a6ca7 
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.7.2 | 0.8.0 |


## [v0.8.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.8.0)

#####    🚨 Breaking Changes

-   **vue-tsc**: Updated createVueLanguagePlugin syntax, version pin  -  by [@daniluk4000](https://github.com/daniluk4000) and **drodichkin** in fi3ework/vite-plugin-checker#398 [<samp>(5f5b9)</samp>](fi3ework/vite-plugin-checker@5f5b92a)

    Now, vite-plugin-checker requires `"vue-tsc": "~2.1.6"`.

#####    🚀 Features

-   Advance typescript teminal consolelog text color  -  by [@jaceechan](https://github.com/jaceechan) in fi3ework/vite-plugin-checker#393 [<samp>(aa3d4)</samp>](fi3ework/vite-plugin-checker@aa3d413)

#####    🐞 Bug Fixes

-   **ui**: Use a Vue key so file paths update correctly  -  by [@artursapek](https://github.com/artursapek) in fi3ework/vite-plugin-checker#389 [<samp>(fcbb6)</samp>](fi3ework/vite-plugin-checker@fcbb687)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.8.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fi3ework fi3ework fi3ework approved these changes

@tryforceful tryforceful tryforceful approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@daniluk4000 @nielsvh2103 @fi3ework @tryforceful