Fix pbp_pass YAC, closes #19 (#21)

ffverse · Aug 9, 2024 · ccae89c · ccae89c
1 parent d9329ab
commit ccae89c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,10 +1,9 @@
 Package: ffopportunity
 Title: Models for Fantasy Football Expected Points
-Version: 0.1.0.06
+Version: 0.1.0.07
 Authors@R: c(
     person("Joe", "Sydlowski", , "[email protected]", role = c("aut", "cre", "cph")),
-    person("Tan", "Ho", , "[email protected]", role = "aut",
-           comment = c(ORCID = "0000-0001-8388-5155"))
+    person("Tan", "Ho", , "[email protected]", role = "aut", comment = c(ORCID = "0000-0001-8388-5155"))
   )
 Description: Downloads expected fantasy points data from 'ffverse'
     repositories if available, and otherwise builds up expected points

diff --git a/NEWS.md b/NEWS.md
@@ -9,3 +9,4 @@
 * Combine variants of ep_load into one function `ep_load()` with arguments
 * Rename to ffopportunity
 * Include spikes and kneel downs to tie out to official stats with `ep_summarize()`
+* Fix YAC bug in pbp_pass data
diff --git a/R/ep_preprocess.R b/R/ep_preprocess.R
@@ -72,8 +72,7 @@ ep_preprocess <- function(pbp){
         stringr::str_detect(.data$desc, " right") ~ "right",
         stringr::str_detect(.data$desc, " middle") ~ "middle",
         TRUE ~ "unk"),
-      yards_after_catch = dplyr::if_else(
-        .data$two_point_attempt == 1,0, .data$xpass),
+      yards_after_catch = dplyr::if_else(.data$two_point_attempt == 1, 0, .data$yards_after_catch),
       air_yards = dplyr::if_else(
         .data$two_point_attempt == 1, .data$yardline_100, .data$air_yards),
       two_point_converted = dplyr::case_when(