Signing contributions is required not recommended #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
reviewed
Nov 27, 2024
content/spin/v3/contributing-docs.md
Outdated
| @@ -527,17 +529,19 @@ $ git config user.name "yourusername" | |||
| $ git config user.email "[email protected]" | |||
| ``` | |||
|
|
|||
| More information can be found at this GitHub documentation page called [signing commits](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits). | |||
| More information can be found at [the GitHub documentation page for signing commits](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits). | |||
There was a problem hiding this comment.
Should this come after the next paragraph?
There was a problem hiding this comment.
Hmm, I've borked something somewhere. I thought I was copying a link about signing but you're right, this is a link about verification. Fie!
There was a problem hiding this comment.
Okay I think that should be less worse now. Thanks for the catch!
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
tweak-signing-docs
branch
from
74736d2
to
3a15022
Compare
karthik2804
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title,template, anddateare all settemplates/*.hbsfiles) that points to a document.mdthat is set to publish in the future? If so please only publish the.mdand.hbschanges in real-time (otherwise there will be a menu item pointing to a.mdfile that does not exist)cat -ve <filename> | grep $'\r' | wc -land expect 0 as a result)bart checkPREVIEW_MODE=1and runnpm run stylesto update styling)npm run testand resolved all errors