Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade esbuild to 0.24.0 #1934

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

vraravam
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade esbuild to the latest version with accompanying changes in the APIs

Motivation and Context

Upgrade outdated packages.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team October 20, 2024 08:27
@vraravam vraravam self-assigned this Oct 20, 2024
@vraravam
Copy link
Contributor Author

@vraravam has tested on mac on m1 (build the app and run it as a standalone app (not as a debug/dev mode with hot-reload - which stopped working for me approx 1 year ago)

@vraravam vraravam marked this pull request as draft October 20, 2024 11:56
@Alphrag
Copy link
Member

Alphrag commented Oct 20, 2024

The build script doesn't work because of the tsc call in the pnpm prepare-code (this made me realise that this is not done in the gh action build), but the rest goes through fine.
Capture d’écran 2024-10-20 à 14 30 34

@vraravam
Copy link
Contributor Author

vraravam commented Oct 21, 2024

The build script doesn't work because of the tsc call in the pnpm prepare-code (this made me realise that this is not done in the gh action build), but the rest goes through fine.

I don't think this is the case, since prepare-code is being called here

Also, on my local, I'm able to get a fully green build ie which results in a zero exit code when invoking the scripts/build-unix.sh script. If you are testing on windows, is that script out of date?

@Alphrag
Copy link
Member

Alphrag commented Oct 21, 2024

Oh you're right, I was looking for it next to the lint and test, and didn't think of looking there.
No, I am testing it on mac, with a CLEAN=true ./scripts/build-unix.sh and got the same error on both x64 and M3.

@vraravam vraravam force-pushed the esbuild-0.24.0 branch 3 times, most recently from f1e34d6 to a28cf2b Compare October 26, 2024 02:03
@vraravam vraravam force-pushed the esbuild-0.24.0 branch 5 times, most recently from 138f555 to 2e963e1 Compare November 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants