Merge pull request #56 from feedhenry/race-condition

Fix to cope with race condition with multiple refs for one sync record
feedhenry · Dec 19, 2019 · b1c7c8a · b1c7c8a
2 parents 8733af9 + 3ccb1c8
commit b1c7c8a
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/storage/dataset-clients.js b/lib/storage/dataset-clients.js
@@ -154,6 +154,8 @@ function upsertOrDeleteDatasetRecords(datasetId, datasetClientId, records, cb) {
     } else if (op === 'delete') {
       //remove the ref
       update['$pull'] = {'refs': datasetClientId};
+      // also set the hash to null to handle race condition when multiple refs associated with single record
+      update['$set']['hash'] = null;
     }
     datasetRecordsCol.findOneAndUpdate({uid: record.uid}, update, {upsert: true, returnOriginal: false}, function(err, updated) {
       if (err) {